Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ggplot survival curves #16

Merged
merged 5 commits into from
May 8, 2023
Merged

feat: ggplot survival curves #16

merged 5 commits into from
May 8, 2023

Conversation

ESCRI11
Copy link
Contributor

@ESCRI11 ESCRI11 commented Apr 26, 2023

Added the option to plot using ggplot (survminer::ggsurvplot) to obtain easier to read plots. Especially good for stratified survival analysis.

E.g.:

image

@neelsoumya
Copy link
Owner

neelsoumya commented Apr 26, 2023

Thanks @ESCRI11 can you please sync with the main branch and then resend this pull request. I am getting merge conflicts. It says your branch is 255 commits behind.

@neelsoumya neelsoumya self-assigned this Apr 28, 2023
@ESCRI11
Copy link
Contributor Author

ESCRI11 commented Apr 28, 2023

Synced with main branch. Now it should be ok

@neelsoumya
Copy link
Owner

Thanks @ESCRI11 !
great work!
Could you please update the DESCRIPTION file also with an updated version number? e.g. 2.1.3

@ESCRI11
Copy link
Contributor Author

ESCRI11 commented Apr 28, 2023

Done

@neelsoumya
Copy link
Owner

thanks @ESCRI11 !

@StuartWheater
Copy link
Contributor

Results of devtools::check()

❯ checking for portable file names ... WARNING
Found the following file with a non-portable file name:
dssurvival lay summary.pdf
These are not fully portable file names.
See section ‘Package structure’ in the ‘Writing R Extensions’ manual.
Found the following non-portable file paths:
dsSurvivalClient/tests/testthat/data_files/SURVIVAL/COLLAPSE_NO_MISSING/collapse_no_missing_study1.csv
dsSurvivalClient/tests/testthat/data_files/SURVIVAL/COLLAPSE_NO_MISSING/collapse_no_missing_study2.csv
dsSurvivalClient/tests/testthat/data_files/SURVIVAL/COLLAPSE_NO_MISSING/collapse_no_missing_study3.csv

Tarballs are only required to store paths of up to 100 bytes and cannot
store those of more than 256 bytes, with restrictions including to 100
bytes for the final component.
See section ‘Package structure’ in the ‘Writing R Extensions’ manual.

❯ checking package subdirectories ... WARNING
Invalid citation information in ‘inst/CITATION’:
Error in bibentry(bibtype = entry, textVersion = textVersion, header = header, footer = footer, ...): argument is missing, with no default

❯ checking Rd \usage sections ... WARNING
Undocumented arguments in documentation object 'ds.plotsurvfit'
‘ggplot’

Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.

❯ checking files in ‘vignettes’ ... WARNING
Files in the 'vignettes' directory but no files in 'inst/doc':
‘readme.md’
Package has no Sweave vignette sources and no VignetteBuilder field.

❯ checking for hidden files and directories ... NOTE
Found the following hidden files and directories:
.github
These were most likely included in error. See section ‘Package
structure’ in the ‘Writing R Extensions’ manual.

❯ checking top-level files ... NOTE
Non-standard files/directories found at top level:
‘LICENSE.md’ ‘dssurvival lay summary.pdf’

❯ checking dependencies in R code ... NOTE
Namespaces in Imports field not imported from:
‘data.table’ ‘fields’ ‘gridExtra’ ‘survival’
All declared Imports should be used.

@neelsoumya neelsoumya merged commit 9093446 into neelsoumya:main May 8, 2023
@neelsoumya
Copy link
Owner

thanks @ESCRI11 @StuartWheater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants