Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfers fail when started from .onInit (GH-6 regression) #7

Closed
negrutiu opened this issue Apr 9, 2023 · 0 comments
Closed

Transfers fail when started from .onInit (GH-6 regression) #7

negrutiu opened this issue Apr 9, 2023 · 0 comments
Assignees
@negrutiu
Labels
bug Something isn't working

Comments

@negrutiu
Copy link
Owner

negrutiu commented Apr 9, 2023

When called from the .onInit NSIS function, transfers will not start.
This is a regression caused by the security checks added in GH-6.
Exported functions receive a NULL parent window during .onInit, which is quickly rejected by our new validations.
NULL windows should be treated as valid.
@negrutiu negrutiu added the bug Something isn't working label Apr 9, 2023
@negrutiu negrutiu self-assigned this Apr 9, 2023
negrutiu added a commit that referenced this issue Apr 9, 2023
@negrutiu
GH-7: Fixed parameter validation during .onInit
986f66c
@negrutiu negrutiu closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negrutiu negrutiu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@negrutiu