Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code_clean_up #339

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Code_clean_up #339

merged 3 commits into from
Oct 5, 2021

Conversation

divshacker
Copy link
Contributor

fixes #338

@vercel
Copy link

vercel bot commented Oct 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/negu3/meme-box/7JkQuiKoB6igsR1AYNADys2XtSW5
✅ Preview: https://meme-box-git-fork-divshacker-clean-code-negu3.vercel.app

@divshacker
Copy link
Contributor Author

I have done the necessary changes as suggested by https://deepsource.io/gh/negue/meme-box/issue/JS-0128/occurrences/

@negue
Copy link
Owner

negue commented Oct 4, 2021

I didn't saw that all of these occurrences are IN memebox-streamdeck , I thought those were in ALL files thats why I wrote ths before

I think some of the folders you can ignore, for example the files in memebox-streamdeck some of the code is not from me and there it might be nice to know which possible values the methods can get.

Need to go through those changes - some need to be reverted (sadly this part isn't inside the CI / Test Pipeline so I need to check it manually)

Will have the review ready in some minutes

Copy link
Owner

@negue negue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some needed reverts but otherwise I think those are good 👍

Thank you

memebox-streamdeck/public/common.js Outdated Show resolved Hide resolved
memebox-streamdeck/public/common.js Show resolved Hide resolved
memebox-streamdeck/scripts/build.js Show resolved Hide resolved
@negue
Copy link
Owner

negue commented Oct 5, 2021

Thank you for your contribution :)

Would you also like to be added to the contributors list? => https://github.com/negue/meme-box#contributors-

@negue negue merged commit 0ab99e8 into negue:develop Oct 5, 2021
@divshacker
Copy link
Contributor Author

Yes Please add me.
Also I think this contribution would be marked as Hacktober fest accepted 😅
As this issue was posted on deepsource and I reached out from there and contributed to this repo. So I thought this PR would be marked Hactkober fest accepted.

@negue
Copy link
Owner

negue commented Oct 5, 2021

@all-contributors please add @divshacker for code

@divshacker Since the PR was merged - it is automatically approved for hacktober :)

The hacktoberfest-accepted is only needed for PRs that take longer to do than the period of October

@allcontributors
Copy link
Contributor

@negue

I've put up a pull request to add @divshacker! 🎉

@divshacker divshacker deleted the clean-code branch October 11, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not have unused variables
2 participants