-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code_clean_up #339
Code_clean_up #339
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/negu3/meme-box/7JkQuiKoB6igsR1AYNADys2XtSW5 |
I have done the necessary changes as suggested by https://deepsource.io/gh/negue/meme-box/issue/JS-0128/occurrences/ |
I didn't saw that all of these occurrences are IN
Need to go through those changes - some need to be reverted (sadly this part isn't inside the CI / Test Pipeline so I need to check it manually) Will have the review ready in some minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some needed reverts but otherwise I think those are good 👍
Thank you
Thank you for your contribution :) Would you also like to be added to the contributors list? => https://github.com/negue/meme-box#contributors- |
Yes Please add me. |
@all-contributors please add @divshacker for code @divshacker Since the PR was merged - it is automatically approved for hacktober :) The |
I've put up a pull request to add @divshacker! 🎉 |
fixes #338