-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add Nx #348
build: add Nx #348
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/negu3/meme-box/DMZr736ewT4hWGJJkkg96XVAt9nS |
Wooooot!!! awesome 🤩 THANK YOU!! Did you used any of the existing schematics to convert it to nx or was this all done by hand? :O |
It was a mix of both 😅. You have multiple projects already, and the existing one to migrate to an Nx workspace currently only supports one project. So I ran
Then I took all but one project out of the angular.json and ran
To fix the Angular config. After that, it was tweaking some of the config files to reference If it were a single project Angular CLI project, I would just use
And remove the |
It did surface some circular dependencies but you probably already knew about those. I did have to turn off automatically building all the dependencies |
Woah .... this should be a blog post :D or if it already exist - I couldn't find it! Thank you for the PR! This will really help as base for more awesome nrwl stuff to add.
I saw some but yes those will probably the first things to add now like also adding more lints ... so there is still lots more to go haha Would you like to be also added to the contributors list on the readme? |
Sure I don't mind being added. A blog post is on the list! 😁 |
Awesome! @all-contributors please add @brandonroberts for code
Hehe, perfect! 😁 |
I've put up a pull request to add @brandonroberts! 🎉 |
This integrates Nx into the monorepo to manage the build tooling.
ng
commands are handled bynx
Closes #342