-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#336/Fix broken unit tests caused by react-children-utilities dependency. #352
Closed
abrie
wants to merge
12
commits into
neherlab:master
from
abrie:remove-react-children-utilities-dependency
Closed
#336/Fix broken unit tests caused by react-children-utilities dependency. #352
abrie
wants to merge
12
commits into
neherlab:master
from
abrie:remove-react-children-utilities-dependency
Commits on Apr 1, 2020
-
Refactor how labels/text are passed to FormHelpButton.
This removes the react-children-utilities dependency, which fixes the tests without requiring module transpilation. The FormHelpButton uses the label field to label the help box, so if the label is a React Node then the text is difficult to access programmatically. The previous implementation used a 3rd party dependency, react-children-utilities, to extract the text. But the dependency breaks the unit tests because the module format is not supported by Jest. This commit creates a HelpProps interface to communicate help label and text to the FormHelpButton. This is more explicit, and avoids the need for another dependency.
Configuration menu - View commit details
-
Copy full SHA for af0db3d - Browse repository at this point
Copy the full SHA af0db3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bc1add - Browse repository at this point
Copy the full SHA 0bc1addView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ded2c9 - Browse repository at this point
Copy the full SHA 2ded2c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a9794c - Browse repository at this point
Copy the full SHA 9a9794cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aff2ba4 - Browse repository at this point
Copy the full SHA aff2ba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45727eb - Browse repository at this point
Copy the full SHA 45727ebView commit details
Commits on Apr 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for aef1621 - Browse repository at this point
Copy the full SHA aef1621View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b8bf77 - Browse repository at this point
Copy the full SHA 0b8bf77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44676e4 - Browse repository at this point
Copy the full SHA 44676e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 547521b - Browse repository at this point
Copy the full SHA 547521bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30fc208 - Browse repository at this point
Copy the full SHA 30fc208View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2bdeaa - Browse repository at this point
Copy the full SHA d2bdeaaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.