Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#336/Fix broken unit tests caused by react-children-utilities dependency. #352

Closed

Commits on Apr 1, 2020

  1. Refactor how labels/text are passed to FormHelpButton.

    This removes the react-children-utilities dependency,
    which fixes the tests without requiring module transpilation.
    
    The FormHelpButton uses the label field to label the help box, so if the label is a React Node then the text is difficult to access programmatically. The previous implementation used a 3rd party dependency, react-children-utilities, to extract the text. But the dependency breaks the unit tests because the module format is not supported by Jest. This commit creates a HelpProps interface to communicate help label and text to the FormHelpButton. This is more explicit, and avoids the need for another dependency.
    abrie committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    af0db3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bc1add View commit details
    Browse the repository at this point in the history
  3. Apply yarn lint:fix.

    abrie committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2ded2c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a9794c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aff2ba4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    45727eb View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Configuration menu
    Copy the full SHA
    aef1621 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b8bf77 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44676e4 View commit details
    Browse the repository at this point in the history
  4. Fix broken code typo.

    abrie committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    547521b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    30fc208 View commit details
    Browse the repository at this point in the history
  6. eslint --fix

    abrie committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    d2bdeaa View commit details
    Browse the repository at this point in the history