Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic on unexpected key format #85

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Do not panic on unexpected key format #85

merged 3 commits into from
Aug 23, 2023

Conversation

pontus
Copy link
Contributor

@pontus pontus commented Aug 23, 2023

We used to panic on non-PEM-encoded keys, don't do that.

Also, some PEM-areas with less data than expected would also cause panics, fixes that as well.

@pontus pontus requested a review from blankdots August 23, 2023 07:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #85 (48a0c2e) into master (c6719a4) will increase coverage by 0.69%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   65.54%   66.24%   +0.69%     
==========================================
  Files           6        6              
  Lines        1164     1176      +12     
==========================================
+ Hits          763      779      +16     
+ Misses        281      278       -3     
+ Partials      120      119       -1     
Flag Coverage Δ
unittests 66.24% <100.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keys/keys.go 62.24% <100.00%> (+2.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pontus pontus requested review from pahatz and jbygdell August 23, 2023 07:21
@pontus pontus merged commit 81777f2 into master Aug 23, 2023
6 checks passed
@pontus pontus deleted the keys_no_panic branch August 23, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants