Can cache container as a runtime option. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmarcotte
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Tentative Approval. Ideally I'd like to see the README updated to include this, but if we're keeping this as an undocumented feature until we're sold on the idea, I'm fine leaving it out for now. It also doesn't make things worse not having it, but we should probably at least create a ticket to add it to the readme so we don't forget (but I feel like adding it to the readme is easier than the overhead of a new ticket).
| public function getCanCacheContainer(): bool | ||
| { | ||
| if ($this->CanCacheContainer === null) { | ||
| $this->CanCacheContainer = $this->getCanCacheContainerFromEnvironment(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.