-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUPH-117 | add docs for V1 tokenization and Compilation #67
BUPH-117 | add docs for V1 tokenization and Compilation #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahaha, that's kind of a mess
|Regex|`namespace(\s+)Neighborhoods\\BuphaloTemplateTree\\PrimaryActorName`|`namespace **NAMESPACE_PREFIX_TOKEN****NAMESPACE_RELATIVE_TOKEN**\**PRIMARY_ACTOR_SHORT_PASCAL_CASE_NAME_TOKEN**`| | ||
|Regex|`namespace(\s+)Neighborhoods\\BuphaloTemplateTree`|`namespace **NAMESPACE_PREFIX_TOKEN****NAMESPACE_RELATIVE_TOKEN**`| | ||
|Regex|`use(\s+)Neighborhoods\\BuphaloTemplateTree\\PrimaryActorName`|`use **NAMESPACE_PREFIX_TOKEN****NAMESPACE_RELATIVE_TOKEN**\**PRIMARY_ACTOR_SHORT_PASCAL_CASE_NAME_TOKEN**`| | ||
|Regex|`use(\s+)Neighborhoods\\BuphaloTemplateTree/`|`use **NAMESPACE_PREFIX_TOKEN**`| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the trailing slash here intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah looks like you fixed it in a subsequent PR
|String|`PrimaryActorNameInterface`|`**PRIMARY_ACTOR_SHORT_PASCAL_CASE_NAME_TOKEN**Interface`| | ||
|String|`{Template File Name}Interface`|`**SHORT_PASCAL_CASE_NAME_TOKEN**Interface`| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would seem like these can be "combined" with the versions that have preceding \
s (or really those earlier rows can be omitted?)
but if there's an implied ^
or \s
in front of each of these, then nevermind
or there may be some other reason these should be separate, e.g. this is a literal catalog of what the code does and the code treats these separately, despite the overlap. thus a reason for a v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a literal catalog of what the code does and the code treats these separately, despite the overlap. thus a reason for a v2.
☝🏻
Yup. The current code is a mess and a lot of it could probably be simplified in ways that would not result in any functional changes.
No description provided.