attempt to fix error handlers for PHP 8.1 #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.php.net/manual/en/function.set-error-handler.php
It appears that it's not breaking in 8.0 because the underlying issue that throws to these isn't being triggered, which is a separate Symfony issue. We'll need to upgrade Symfony to a version which supports PHP 8.1 for that. This at least fixes our own issue and allowed us to see the underlying one.
I thought about removing it, but figured we can save that for whatever version requires PHP 8.