Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix error handlers for PHP 8.1 #69

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

jpmarcotte
Copy link
Contributor

@jpmarcotte jpmarcotte commented Oct 4, 2021

From https://www.php.net/manual/en/function.set-error-handler.php

Warning This parameter has been DEPRECATED as of PHP 7.2.0, and REMOVED as of PHP 8.0.0. If your function defines this parameter without a default, an error of "too few arguments" will be raised when it is called.

It appears that it's not breaking in 8.0 because the underlying issue that throws to these isn't being triggered, which is a separate Symfony issue. We'll need to upgrade Symfony to a version which supports PHP 8.1 for that. This at least fixes our own issue and allowed us to see the underlying one.

I thought about removing it, but figured we can save that for whatever version requires PHP 8.

@jpmarcotte jpmarcotte self-assigned this Oct 4, 2021
@jpmarcotte jpmarcotte merged commit 9159d4d into master Oct 11, 2021
@jpmarcotte jpmarcotte deleted the HOTFIX-error-handlers-for-php81 branch October 11, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants