Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUPH-143 | make API Dumper basePath optional #76

Merged
merged 1 commit into from
Feb 18, 2022
Merged

BUPH-143 | make API Dumper basePath optional #76

merged 1 commit into from
Feb 18, 2022

Conversation

jpmarcotte
Copy link
Contributor

@jpmarcotte jpmarcotte commented Feb 17, 2022 •
edited
Loading

Also move Filesystem construction to be lazy loaded.

This allows for either new Dumper() or new Dumper(null) if you want to be explicit.

@jpmarcotte jpmarcotte self-assigned this Feb 17, 2022
@jpmarcotte jpmarcotte merged commit 78e5670 into 1.x Feb 18, 2022
@jpmarcotte jpmarcotte deleted the BUPH-143-api-objects-and-dumper branch February 18, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucha55 mucha55 mucha55 approved these changes

@arielallon arielallon arielallon approved these changes

Assignees

@jpmarcotte jpmarcotte

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmarcotte @arielallon @mucha55