Merge pull request #21 from neighborhoods/bugfix/remove-deprecated-pl…

…ugin bugfix
neighborhoods · Mar 16, 2017 · 0737b23 · 0737b23
2 parents 0170351 + a264319
commit 0737b23
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/js/package.json b/js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-neighborhoods",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "Neighborhoods.com Javascript Style Guide",
   "keywords": [
     "nhds",
@@ -19,7 +19,6 @@
   "license": "MIT",
   "dependencies": {
     "eslint-plugin-import": "2.2.0",
-    "eslint-plugin-import-order": "2.1.4",
     "eslint-plugin-jsx-a11y": "4.0.0",
     "eslint-plugin-react": "6.10.0"
   }

diff --git a/js/react/rules/react-a11y.js b/js/react/rules/react-a11y.js
@@ -7,6 +7,15 @@ module.exports = {
     jsx: true
   },
   rules: {
+    // Don't allow distracting UI elements
+    // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-distracting-elements.md
+    'jsx-a11y/no-distracting-elements': [2, {
+      'elements': [
+        'marquee',
+        'blink'
+      ],
+    }],
+
     // Enforce all aria-* props are valid.
     // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-props.md
     'jsx-a11y/aria-props': 2,
@@ -54,6 +63,7 @@ module.exports = {
       components: ['Label']
     }],
 
+
     // require HTML element's lang prop to be valid
     // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/lang.md
     'jsx-a11y/lang': 2,