Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPS-1109 | Set the ServerVersion using \PDO #5

Merged
merged 3 commits into from
Jun 13, 2018
Merged

OPS-1109 | Set the ServerVersion using \PDO #5

merged 3 commits into from
Jun 13, 2018

Conversation

alexberryman
Copy link
Contributor

@alexberryman alexberryman commented Jun 12, 2018 •
edited
Loading

Set the ServerVersion using \PDO to allow the selection of Mysql57Platform() based on server version. This allows Kōjō to be installed on MySQL Databases with json fields.

@alexberryman
OPS-1109 | Use PDOConnection since it implements ServerInfoAwareConne…
ea28283 
…ction and

allows selection of Mysql57Platform based on server version
@alexberryman alexberryman self-assigned this Jun 12, 2018
@alexberryman alexberryman requested a review from rhift June 12, 2018 19:36
@alexberryman
OPS-1109 | Revert "OPS-1109 | Use PDOConnection since it implements S…
47f819f 
…erverInfoAwareConnection and allows selection of Mysql57Platform based on server version"

This reverts commit ea28283
@alexberryman
OPS-1109 | define a serverVersion so that Doctrine can pick the corre…
693a87b 
…ct platform
rhift
rhift approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@rhift rhift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much #perfect #elegantaf

@alexberryman alexberryman changed the title OPS-1109 | Use PDOConnection instead of \PDO OPS-1109 | Set the ServerVersion using \PDO Jun 13, 2018
@alexberryman alexberryman merged commit 98a6798 into master Jun 13, 2018
@alexberryman alexberryman deleted the bugfix/OPS-1109 branch July 2, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhift rhift rhift approved these changes

Assignees

@alexberryman alexberryman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexberryman @rhift