Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map tiling support (merge orta/NAMapKit) #13

Closed
dblock opened this issue Mar 5, 2014 · 2 comments
Closed

Add map tiling support (merge orta/NAMapKit) #13

dblock opened this issue Mar 5, 2014 · 2 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Mar 5, 2014

We've been working off a fork of NAMapKit for the Artsy iPhone app (http://iphone.artsy.net, try the Armory Show). That code diff is orta/NAMapKit@neilang:master...master. It will take a bit of effort to merge. Most importantly it supports image tiling.

I think there're really two things:

  • Generalize annotations, we hacked NAPinAnnotationView, but we should extract the annotations into something that supports a protocol so that ours can be its own thing.
  • Rebuild tiling on top with a working example.

@orta who wrote a lot of this code will comment here

@neilang There hasn't been much development here for a bit, can we count on you to be looking at PRs?

@neilang
Copy link
Owner

neilang commented Mar 5, 2014

Thanks @orta and @dblock, I think this is a great feature to add. There is a lot of code there so I will try and review it this weekend and see how we can merge it in.

@tonyarnold and @donny can also accept PRs, so between all 3 of us I think we can get it added.

@dblock
Copy link
Collaborator Author

dblock commented Mar 6, 2014

Thanks @neilang. I'll do the work, no stress :) Stay tuned, first PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants