This repository has been archived by the owner on Jul 10, 2020. It is now read-only.
Only the Checkbox element helper displays a (group) label by itself, multi_checkbox and radio removed. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multi_checkbox and radio removed. Labels for the whole group does not get rendered by the element helpers for multi checkbox and radio. Therefore only checkbox should take a different path. Note: Multi Checkbox is still not rendered in a fieldset, this change does not influence that.
|
Please update the tests to cover your changes |
neilime
added a commit
that referenced
this pull request
Oct 25, 2013
|
Sorry, I've made several changes so your PR was in conflict, but I include your change in the current version |
|
No problem, it is perfect! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels for the whole group does not get rendered by the element helpers for multi checkbox and radio. Therefore only checkbox should take a different path.
Note: Multi Checkbox is still not rendered in a fieldset, this change does not influence that.