-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 1.10 compatibility #16
Conversation
1 similar comment
Anything I can do to help get this pull request merged in? |
Hi all, thank you for your interest and effort. I had very little spare time for this project (and anything Django-specific) lately. Merging this into master for now. The next release will be out no earlier than next weekend, maybe later. Please let me know if it's a problem, otherwise I'm assuming that the users are OK with pinning their projects to a commit, not a version. |
Hi. Is there some news about the pypi release? |
@neithere thanks for your time! Perhaps if you're out of time for this project, you could provide maintainer privileges to some contributors? |
Another option would be to join some non-profit such as JazzBand or YourLabs. |
Dear fellow developers, sorry for the delay. Prioritizing this, will try to deal with it during upcoming weekend.
Sure, I'd be happy to do so. The question is to whom.
Great idea. I had to google them up, will need to investigate a bit. Any hint which would be better? |
JazzBand is more recent and bigger. |
Okay, most probably I'll move the project there then. I still don't understand though whether it's possible to move the issues and pending pull requests along with the code. |
Hi.
This PR bring django 1.10 compatibility. There was just one uncompatible function (get_field_by_name).
Also with django 1.10, running tests with
python -Wall run_tests.py
show some django 2.0 deprecations that are also fixed.on_delete
parameter will become mandatory. So I explicitely set the default value, that isCASCADE
.There is still a django 2.0 deprecation that I did not remove. Replacing imports from
django.core.urlresolvers
bydjango.urls
would break 1.7 compatibility.https://docs.djangoproject.com/en/1.10/ref/urlresolvers/
@neithere, what do you think?