Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.10 compatibility #16

Merged
merged 3 commits into from
Oct 16, 2016
Merged

Django 1.10 compatibility #16

merged 3 commits into from
Oct 16, 2016

Conversation

azmeuk
Copy link
Contributor

@azmeuk azmeuk commented Aug 17, 2016

Hi.
This PR bring django 1.10 compatibility. There was just one uncompatible function (get_field_by_name).

Also with django 1.10, running tests with python -Wall run_tests.py show some django 2.0 deprecations that are also fixed. on_delete parameter will become mandatory. So I explicitely set the default value, that is CASCADE.

There is still a django 2.0 deprecation that I did not remove. Replacing imports from django.core.urlresolvers by django.urls would break 1.7 compatibility.
https://docs.djangoproject.com/en/1.10/ref/urlresolvers/

@neithere, what do you think?

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage increased (+1.2%) to 87.767% when pulling 2d26169 on azmeuk:django-deprecations into a16fd5e on neithere:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 87.767% when pulling 2d26169 on azmeuk:django-deprecations into a16fd5e on neithere:master.

@pydanny
Copy link

pydanny commented Sep 16, 2016

Anything I can do to help get this pull request merged in?

@pydanny pydanny mentioned this pull request Sep 16, 2016
@neithere
Copy link
Collaborator

Hi all, thank you for your interest and effort. I had very little spare time for this project (and anything Django-specific) lately. Merging this into master for now. The next release will be out no earlier than next weekend, maybe later. Please let me know if it's a problem, otherwise I'm assuming that the users are OK with pinning their projects to a commit, not a version.
Thanks again.

@neithere neithere merged commit 2237710 into justinmayer:master Oct 16, 2016
@azmeuk azmeuk deleted the django-deprecations branch October 16, 2016 20:15
@azmeuk
Copy link
Contributor Author

azmeuk commented Nov 25, 2016

Hi. Is there some news about the pypi release?

@aehlke
Copy link

aehlke commented Dec 3, 2016

@neithere thanks for your time! Perhaps if you're out of time for this project, you could provide maintainer privileges to some contributors?

@jpic
Copy link

jpic commented Feb 7, 2017

Another option would be to join some non-profit such as JazzBand or YourLabs.

@neithere
Copy link
Collaborator

neithere commented Feb 7, 2017

Dear fellow developers, sorry for the delay. Prioritizing this, will try to deal with it during upcoming weekend.

you could provide maintainer privileges to some contributors

Sure, I'd be happy to do so. The question is to whom.

join some non-profit such as JazzBand or YourLabs

Great idea. I had to google them up, will need to investigate a bit. Any hint which would be better?

@jpic
Copy link

jpic commented Feb 8, 2017

JazzBand is more recent and bigger.

@neithere
Copy link
Collaborator

Okay, most probably I'll move the project there then. I still don't understand though whether it's possible to move the issues and pending pull requests along with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants