Fixes #1387

[zukwung]

This fixes #1387, or an attempt at it... please let me know if there are any changes required. Thanks!

[ChristopherHX]

If I think more about the GITHUB_ENV file parser, act is still to restrictive and should allow all chars other than \n and \r as a delimitter after a << token.

[zukwung]

If I think more about the GITHUB_ENV file parser, act is still to restrictive and should allow all chars other than \n and \r as a delimitter after a << token.

I can update it to be .+ if you want @ChristopherHX, up to you

[codecov]

Codecov Report

Merging #1388 (e612e63) into master (4f8da0a) will increase coverage by 6.34%.
The diff coverage is 74.60%.

❗ Current head e612e63 differs from pull request most recent head 5cdea32. Consider uploading reports for the commit 5cdea32 to get more accurate results

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   57.50%   63.85%   +6.34%     
==========================================
  Files          32       41       +9     
  Lines        4594     6452    +1858     
==========================================
+ Hits         2642     4120    +1478     
- Misses       1729     2036     +307     
- Partials      223      296      +73     

Impacted Files	Coverage Δ
pkg/model/action.go	0.00% <0.00%> (ø)
pkg/model/step_result.go	0.00% <ø> (ø)
pkg/container/docker_run.go	12.82% <11.63%> (+7.27%)	⬆️
pkg/model/workflow.go	47.14% <22.22%> (-3.77%)	⬇️
pkg/model/planner.go	48.82% <25.00%> (-1.60%)	⬇️
pkg/container/docker_pull.go	33.33% <33.33%> (ø)
pkg/container/file_collector.go	43.11% <43.11%> (ø)
pkg/common/git/git.go	50.00% <47.91%> (ø)
pkg/container/docker_auth.go	47.61% <50.00%> (+2.61%)	⬆️
pkg/exprparser/interpreter.go	73.37% <53.48%> (-0.02%)	⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChristopherHX]

Thank you it's fine as is from my side, it's good a have one more test for the GITHUB_ENV file.

Act has more defects in that code, like this one:

on: push
jobs:
  _:
    runs-on: ubuntu-latest
    steps:
    - run: |
        echo "test<<World" > $GITHUB_ENV
        echo "x=Thats really Weird" >> $GITHUB_ENV
        echo "World" >> $GITHUB_ENV
    - if: env.test != 'x=Thats really Weird'
      run: exit 1
    - if: env.x == 'Thats really Weird' # This assert is triggered by the broken impl of act
      run: exit 1

just the existing method feels like to need a rewrite ( be aligned to actions/runner's code ) and be factored out into a reusable method.

[zukwung]

just the existing method feels like to need a rewrite ( be aligned to actions/runner's code ) and be factored out into a reusable method.

I'll leave that to the experts 😎 . Is there anything else I need to do before we can merge this fix?

[ChristopherHX]

Get two more approvals from other maintainers.