Go 1.11.4+ and Docker 18.09 pre-reqs #15
Conversation
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
README.md
Outdated
| @@ -57,7 +57,8 @@ Want to contribute to act? Awesome! Check out the [contributing guidelines](CONT | |||
|
|
|||
| ## Building from source | |||
|
|
|||
| * Install Go tools 1.11+ - (https://golang.org/doc/install) | |||
| * Install Go tools 1.11.4+ - (https://golang.org/doc/install) | |||
| * Have a working Docker v18.09.1+ client - local/Docker for Mac/Docker for Windows | |||
There was a problem hiding this comment.
This should not be needed; the client can do API version negotiation; see docker/docs#7710 (comment)
(thinking of making an opt for that, or see if we can make it the default)
There was a problem hiding this comment.
whoops, missed your note about that;
this is probably something that can change, but its true atm
There was a problem hiding this comment.
thanks @thaJeztah for the suggestions, i've incorporated that change just now to enable client negotiation on master
There was a problem hiding this comment.
@SvenDowideit given the change i made to enable client negotiation, can you remove the requirement for having the docker client?
There was a problem hiding this comment.
yup - I'll see if i can find something old to test on :)
Fix nektos#15. Reviewed-on: https://gitea.com/gitea/act/pulls/16 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Jason Song <i@wolfogre.com> Co-committed-by: Jason Song <i@wolfogre.com>
mention you need DOcker 18.09 - #14 (this is probably something that can change, but its true atm)
also suggest go 1.11.4 - with 1.11.3 and 1.11.1 I got version missmatch errors from
go mod- see moby/moby#38507 (comment)Signed-off-by: Sven Dowideit SvenDowideit@home.org.au