Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): chocolatey - update alpine to 3.17 #1512

Closed
wants to merge 1 commit into from

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Dec 18, 2022

I updated two PR's and the snapshot fails, because the latest mono-dev fails to find it's dependency in the old alpine base image

This package is not found in v3.16 or older
https://pkgs.alpinelinux.org/packages?name=libgdiplus-dev&branch=v3.17&repo=&arch=&maintainer=

@ChristopherHX ChristopherHX requested a review from a team as a code owner December 18, 2022 12:18
@ChristopherHX ChristopherHX changed the title fix: ci snaphot job fix: ci snapshot job Dec 18, 2022
@github-actions
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.0s
✅ REPOSITORY gitleaks yes no 2.87s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.19s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #1512 (09dd1d5) into master (4f8da0a) will increase coverage by 3.85%.
The diff coverage is 67.64%.

@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
+ Coverage   57.50%   61.36%   +3.85%     
==========================================
  Files          32       46      +14     
  Lines        4594     7121    +2527     
==========================================
+ Hits         2642     4370    +1728     
- Misses       1729     2444     +715     
- Partials      223      307      +84     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/parse_env_file.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 13.58% <11.48%> (+8.04%) ⬆️
pkg/model/workflow.go 42.11% <18.51%> (-8.80%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChristopherHX
Copy link
Contributor Author

Seems like alpine uploaded the missing package to alpine 3.16 today, but updating alpine is still a good idea.

@ChristopherHX ChristopherHX changed the title fix: ci snapshot job deps: ci chocolatey - update alpine to 3.17 Dec 19, 2022
@ChristopherHX ChristopherHX changed the title deps: ci chocolatey - update alpine to 3.17 build(deps): chocolatey - update alpine to 3.17 Dec 19, 2022
@catthehacker
Copy link
Member

We should switch to https://hub.docker.com/r/chocolatey/choco as it's official image from chocolatey project

@ChristopherHX
Copy link
Contributor Author

I agree, we should switch to the official image. Not shure what needs to be done to switch to the official image.

PR 1514 contains this change, because I was surprised that the PR checks will succeed today without it

@ChristopherHX
Copy link
Contributor Author

Merged implicitly via #1514, not the order I expected

@ChristopherHX ChristopherHX deleted the fix-ci-snaphot-job branch December 19, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants