-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NetBSD #2023
Add support for NetBSD #2023
Conversation
(Rebasing on latest [If any further changes are pushed and I miss them don't hesitate to ping me if needed and I will rebase and repush as needed] |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2023 +/- ##
==========================================
+ Coverage 61.22% 61.64% +0.42%
==========================================
Files 46 53 +7
Lines 7141 8808 +1667
==========================================
+ Hits 4372 5430 +1058
- Misses 2462 2948 +486
- Partials 307 430 +123 ☔ View full report in Codecov by Sentry. |
netbsd was a broken docker client platform in 2021 https://github.com/ChristopherHX/act/blob/fd9f40cdc02dc72c40a9c33450d638d6e8e8ee57/pkg/container/docker_build.go#L1C1-L2C1 This broke the non docker backend in the past. Since service support has been added you would need to change more built tags otherwise netbsd is broken. |
Hello @ChristopherHX! Marking as draft in the meantime and please ignore it for the moment! Thanks! |
NetBSD can run Docker CLI and then use Docker on some remote machine via DOCKER_HOST. (This can be probably extended to all other Unix-es capable of running just Docker CLI.)
NetBSD can run Docker CLI and then use Docker on some remote machine via DOCKER_HOST. (This can be probably extended to all other Unix-es capable of running just Docker CLI.) Co-authored-by: ChristopherHX <christopher.homberger@web.de>
NetBSD can run Docker CLI and then use Docker on some remote machine via
DOCKER_HOST
.(This can be probably extended to all other Unix-es capable of running just Docker CLI.)
This was done mechanically via:
sed -i -e 's;linux || darwin || windows;linux || darwin || windows || netbsd;' **/*.go
I have tested it only on NetBSD/amd64 via Lima VM and
DOCKER_HOST
set tounix:///${HOME}/.lima/docker/sock/docker.sock
.I think that the same method will probably works on several other Unix-es (
dragonfly
,freebsd
,illumos
,openbsd
,solaris
and maybe others that I could not think of!) as long as they support at least Docker CLI. I have being conservative here to only what I was able to test though, sorry!