Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NetBSD #2023

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add support for NetBSD #2023

merged 2 commits into from
Jan 8, 2024

Conversation

iamleot
Copy link
Contributor

@iamleot iamleot commented Sep 24, 2023

NetBSD can run Docker CLI and then use Docker on some remote machine via DOCKER_HOST.

(This can be probably extended to all other Unix-es capable of running just Docker CLI.)


This was done mechanically via:

sed -i -e 's;linux || darwin || windows;linux || darwin || windows || netbsd;' **/*.go

I have tested it only on NetBSD/amd64 via Lima VM and DOCKER_HOST set to unix:///${HOME}/.lima/docker/sock/docker.sock.

I think that the same method will probably works on several other Unix-es (dragonfly, freebsd, illumos, openbsd, solaris and maybe others that I could not think of!) as long as they support at least Docker CLI. I have being conservative here to only what I was able to test though, sorry!

@iamleot iamleot marked this pull request as ready for review September 24, 2023 20:55
@iamleot iamleot requested a review from a team as a code owner September 24, 2023 20:55
@iamleot iamleot marked this pull request as draft September 25, 2023 09:12
@iamleot
Copy link
Contributor Author

iamleot commented Sep 25, 2023

(Rebasing on latest master and pushing with the --force to avoid drifts.)

[If any further changes are pushed and I miss them don't hesitate to ping me if needed and I will rebase and repush as needed]

@iamleot iamleot marked this pull request as ready for review September 25, 2023 09:17
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 872 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (ff7d134) 61.64%.
Report is 296 commits behind head on master.

Files Patch % Lines
pkg/artifactcache/handler.go 65.46% 102 Missing and 42 partials ⚠️
pkg/runner/run_context.go 73.37% 75 Missing and 19 partials ⚠️
pkg/runner/expression.go 55.17% 66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go 50.74% 49 Missing and 17 partials ⚠️
pkg/container/docker_network.go 0.00% 56 Missing ⚠️
pkg/container/docker_run.go 2.00% 48 Missing and 1 partial ⚠️
pkg/model/workflow.go 43.37% 40 Missing and 7 partials ⚠️
pkg/common/outbound_ip.go 0.00% 44 Missing ⚠️
pkg/container/host_environment.go 0.00% 43 Missing ⚠️
pkg/artifactcache/storage.go 60.22% 24 Missing and 11 partials ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
+ Coverage   61.22%   61.64%   +0.42%     
==========================================
  Files          46       53       +7     
  Lines        7141     8808    +1667     
==========================================
+ Hits         4372     5430    +1058     
- Misses       2462     2948     +486     
- Partials      307      430     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX
Copy link
Contributor

This was done mechanically via:

netbsd was a broken docker client platform in 2021 https://github.com/ChristopherHX/act/blob/fd9f40cdc02dc72c40a9c33450d638d6e8e8ee57/pkg/container/docker_build.go#L1C1-L2C1

This broke the non docker backend in the past. -P netbsd=-self-hosted.

Since service support has been added you would need to change more built tags otherwise netbsd is broken.

@iamleot
Copy link
Contributor Author

iamleot commented Nov 12, 2023

Hello @ChristopherHX!
Thanks, I will try to look at HEAD master in the next weekend and also adjust paths related to service support.

Marking as draft in the meantime and please ignore it for the moment!

Thanks!

@iamleot iamleot marked this pull request as draft November 12, 2023 17:06
NetBSD can run Docker CLI and then use Docker on some remote machine
via DOCKER_HOST.

(This can be probably extended to all other Unix-es capable of running
just Docker CLI.)
@iamleot iamleot marked this pull request as ready for review November 19, 2023 12:43
@mergify mergify bot merged commit adbe229 into nektos:master Jan 8, 2024
10 checks passed
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
NetBSD can run Docker CLI and then use Docker on some remote machine
via DOCKER_HOST.

(This can be probably extended to all other Unix-es capable of running
just Docker CLI.)

Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants