fix: compute ref and ref_name prioritising HEAD pointer if tag is not set #2061
Conversation
| refBranch = r.Name().String() | ||
| } | ||
| } | ||
| // The assumption is made that if the revision has a tag associated with it the ref and ref_name should reference it. |
There was a problem hiding this comment.
I’m not confident of what workflow triggers require the ref and ref_name to be set to the refs/tags prefix and therefore uncertain if this assumption is accurate or even desired.
I’m thinking this is relevant to working with the release workflow trigger?
Either way I’m not looking to change the current behaviour but just fix the value when multiple branches point to the same commit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2061 +/- ##
==========================================
- Coverage 61.22% 61.22% -0.01%
==========================================
Files 46 53 +7
Lines 7141 8755 +1614
==========================================
+ Hits 4372 5360 +988
- Misses 2462 2970 +508
- Partials 307 425 +118 ☔ View full report in Codecov by Sentry. |
|
@GROwen this pull request is now in conflict 😩 |
|
PR is stale and will be closed in 14 days unless there is new activity |
|
The change that this PR is conflicting with could resolve the issue. The change introduced in https://github.com/nektos/act/pull/1530/files needs to be tested against the scenario that was raised in #2056 before I can continue work on this PR. |
Fixes #2056