Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: change automatic merge rules for maintainers #2156

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

cplee
Copy link
Contributor

@cplee cplee commented Jan 18, 2024

ci: automatic merge PRs created by a maintainer and approved by 1 other maintainer

@cplee cplee requested a review from a team as a code owner January 18, 2024 22:44
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.35s
✅ REPOSITORY git_diff yes no 0.17s
✅ REPOSITORY grype yes no 7.96s
✅ REPOSITORY secretlint yes no 1.07s
✅ REPOSITORY trivy-sbom yes no 0.61s
✅ REPOSITORY trufflehog yes no 16.65s
✅ YAML prettier 1 0 0.28s
✅ YAML v8r 1 0 1.59s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 869 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (84425a8) 61.68%.
Report is 297 commits behind head on master.

Files Patch % Lines
pkg/artifactcache/handler.go 66.18% 100 Missing and 41 partials ⚠️
pkg/runner/run_context.go 73.37% 75 Missing and 19 partials ⚠️
pkg/runner/expression.go 55.17% 66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go 50.74% 49 Missing and 17 partials ⚠️
pkg/container/docker_network.go 0.00% 56 Missing ⚠️
pkg/container/docker_run.go 2.00% 48 Missing and 1 partial ⚠️
pkg/model/workflow.go 43.37% 40 Missing and 7 partials ⚠️
pkg/common/outbound_ip.go 0.00% 44 Missing ⚠️
pkg/container/host_environment.go 0.00% 43 Missing ⚠️
pkg/artifactcache/storage.go 60.22% 24 Missing and 11 partials ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
+ Coverage   61.22%   61.68%   +0.45%     
==========================================
  Files          46       53       +7     
  Lines        7141     8808    +1667     
==========================================
+ Hits         4372     5433    +1061     
- Misses       2462     2946     +484     
- Partials      307      429     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cplee cplee merged commit cd40f3f into master Jan 19, 2024
9 checks passed
@cplee cplee deleted the change-approver-rules branch January 19, 2024 15:04
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants