Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn Apple M1 (arm64) users #743

Merged
merged 4 commits into from
Jun 23, 2021
Merged

fix: warn Apple M1 (arm64) users #743

merged 4 commits into from
Jun 23, 2021

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Jun 23, 2021

fixes #742
should look something like this (screenshot from Windows Terminal)
image

@catthehacker catthehacker self-assigned this Jun 23, 2021
@catthehacker catthehacker requested a review from a team as a code owner June 23, 2021 15:29
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #743 (f2adb09) into master (0f04942) will increase coverage by 1.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   49.27%   50.29%   +1.01%     
==========================================
  Files          23       23              
  Lines        2401     2579     +178     
==========================================
+ Hits         1183     1297     +114     
- Misses       1090     1142      +52     
- Partials      128      140      +12     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.84% <0.00%> (-0.09%) ⬇️
pkg/model/workflow.go 25.29% <2.43%> (-0.43%) ⬇️
pkg/common/git.go 52.85% <30.15%> (-6.94%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 75.06% <76.71%> (+6.11%) ⬆️
pkg/runner/run_context.go 79.84% <95.52%> (+3.44%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/logger.go 64.81% <100.00%> (+0.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9fe038...f2adb09. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jun 23, 2021
@catthehacker
Copy link
Member Author

??????????????? linter pls
image

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2021

@catthehacker this pull request has failed checks 🛠

cplee
cplee previously approved these changes Jun 23, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Jun 23, 2021
@mergify mergify bot requested a review from a team June 23, 2021 17:19
@mergify mergify bot merged commit 1cf422e into master Jun 23, 2021
@mergify mergify bot deleted the cat/fix/apple-m1 branch June 23, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Apple Silicon] Failure 255
2 participants