feat: Add ability to configure UI through configuration #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Apr 1, 2024
HypeMC
commented
Apr 1, 2024
DjordyKoert
reviewed
Apr 5, 2024
HypeMC
force-pushed
the
configure-redocly
branch
2 times, most recently
from
626522c
to
f5c5e99
Compare
DjordyKoert
requested changes
Apr 8, 2024
There was a problem hiding this comment.
This configuration option should more generic to potentially allow more options in the future, this also aligns this new configuration option with the DumpCommand --html-config option and also let's it serve as a potential way to customize the default value for --html-config.
DjordyKoert
requested changes
Apr 8, 2024
HypeMC
force-pushed
the
configure-redocly
branch
2 times, most recently
from
ea83245
to
c369078
Compare
DjordyKoert
approved these changes
Apr 8, 2024
HypeMC
force-pushed
the
configure-redocly
branch
from
c369078
to
9e84ef5
Compare
HypeMC
force-pushed
the
configure-redocly
branch
from
9e84ef5
to
2333a54
Compare
|
I've rebased the PR since there were conflicts. |
Thank you! I was planning on doing it myself but I was not able to find the time for it yet :) I will try and have a look at everything later today if my time allows it |
DjordyKoert
changed the title
|
Thank you @HypeMC :) |
DjordyKoert
pushed a commit
that referenced
this pull request
May 29, 2024
| Q | A | |---------------|---------------------------------------------------------------------------------------------------------------------------| | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - Currently the `SwaggerUiController` doesn't respect the `assets_mode` configuration added in #2251. ```yaml nelmio_api_doc: html_config: assets_mode: cdn ``` As far as I can tell, there's no reason for the default any more as it can be set through the configuration and overridden in the `DumpCommand` command using the `html-config` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure the UI through configuration: