Add configuration flag to allow to opt-out from skipping CORS when same as origin #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose introducing a flag that allows the bundle user to opt-out of the default "skip if same as origin" logic done in
CorsListener
(see https://github.com/nelmio/NelmioCorsBundle/blob/master/EventListener/CorsListener.php#L67).As far as I understand allowing this would not violate the CORS spec.
For us this is a valid usage scenario, for reasons which are a bit convoluted to explain, but in short we have a reverse proxy setup where the symfony backend is not aware of all the domains it can be routed through. In this scenario, we are in fact using an
Origin
header which matches (even though the external facing domain does not) the same scheme & http host the symfony backend "sees".With this proposed change nothing would change for current users, while allowing the flexibility for those that want to opt-out to do so without having to override the whole
onKernelRequest
method from the original listener.Any feedback or help refining this is welcomed.