Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Aux directories get created in the wrong place #58

Merged
merged 3 commits into from
May 22, 2017

Conversation

sixhobbits
Copy link
Contributor

With the current instructions in the README, you are told to call make aux_dirs, which calls this script. The directories are all then created two levels too high in the tree, as they are created relative to the main directory.

With the current instructions in the README, you are told to call make aux_dirs, which calls this script. The directories are all then created two levels too high in the tree, as they are created relative to the main directory.
@nelson-liu
Copy link
Owner

nelson-liu commented May 21, 2017

thanks for the PR!

Interestingly, I've specifically tried to fix this before but I guess I failed. Which OS are you running? I had this issue before and I specifically tried to use this line in make_auxiliary_dirs.sh to try to CD to a consistent place across machines (the path of the script), so you should remove that.

Alternatively, I think a cleaner solution might be to just have the code in the actual makefile itself?

What do you think?

@nelson-liu
Copy link
Owner

eh after thinking about it more, i think it's easiest to just remove the explicit CD currently in the file and add a warning that the proper way to run the script is through make as opposed to just running the script directly...

@nelson-liu nelson-liu merged commit ad68112 into nelson-liu:master May 22, 2017
@nelson-liu
Copy link
Owner

Thanks for the help @sixhobbits , I hope you don't mind me finishing up this PR for you (seems like a pretty major setup bug to me, so thanks for catching it)

@sixhobbits
Copy link
Contributor Author

Thanks for fixing! Maybe a python setup script could be more consistent? You can get the directory of the script itself with os.path(file) or something and do everything relative to their so it doesn't matter where people run it from

@sixhobbits
Copy link
Contributor Author

But pretty sure this fixes for large majority so maybe not worth the effort.

@nelson-liu
Copy link
Owner

That's a great idea, but yeah it isn't the top priority for me right now. I've put it on the issue tracker and marked it as "contributions welcome". Thanks for the suggestion @sixhobbits !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants