Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse Event #13

Closed
SwagUX opened this issue Feb 3, 2016 · 2 comments
Closed

Reverse Event #13

SwagUX opened this issue Feb 3, 2016 · 2 comments

Comments

@SwagUX
Copy link

SwagUX commented Feb 3, 2016

I suggest allowing on to have the ripple effect occur when the item is clicked rather than off-clicked.
@mchl18
Copy link

mchl18 commented May 17, 2016

Yes, this would be very nice. I have tried changing the events from "mouseup" and "touchend" to "mousedown" and "touchstart" in the angular-ripple.js out of curiosity and it actually seems to have resolved a bug where the animation didn't fire properly.
Please make this simple change.

MikeMcChillin added a commit that referenced this issue Jun 3, 2016
@MikeMcChillin
Changed touchend to touchstart, mouseup to mousedown. Fixes GH issue #13
5cd9346
@MikeMcChillin
Copy link
Contributor

Great suggestion, change made in version 0.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MikeMcChillin @mchl18 @SwagUX