Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation of Stack Expansion (including Edge Wrapping) #55

Closed
nelsonni opened this issue Jun 16, 2017 · 2 comments
Closed

Reimplementation of Stack Expansion (including Edge Wrapping) #55

nelsonni opened this issue Jun 16, 2017 · 2 comments
Assignees
Milestone

Comments

@nelsonni
Copy link
Owner

The basic requirements for stack expansion remain the same as illustrated in #4. However, since then it has come to light that there is a literal edge case for this functionality. When a stack would normally expand beyond the edge of the canvas, the stack must instead only partially expand in order to prevent cards from being occluded.

To proper avoidance behavior is to emulate the act of dealing from a deck of playing cards. A card is removed from the top of the stack and placed on it's own in the expanding area. This process is repeated, and as a new card is removed from the top it is set down nearest the stack. This will cause the previous card in that position to one card position farther from the stack. This process continues until either all cards are fully expanded from the stack, or the edge has been reached. The following illustration demonstrates this design:
multiple cards

@nelsonni
Copy link
Owner Author

PR #53 provides most of the functionality previously found in #4. However, the order of expansion and location of the remaining stacked cards is not correctly. It currently creates a new stack to the far-right of the expansion area and adds what would have been the unstacked cards into this new stack. Please update this PR to meet this design requirement.

@nelsonni
Copy link
Owner Author

Resolved via PR #53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants