Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua error on discovering Bontom's location (in BfW 1.16) #39

Closed
cooljeanius opened this issue Dec 14, 2021 · 2 comments · Fixed by #43
Closed

Lua error on discovering Bontom's location (in BfW 1.16) #39

cooljeanius opened this issue Dec 14, 2021 · 2 comments · Fixed by #43
Labels
bug Something isn't working
Milestone
1.4.1

Comments

@cooljeanius
Copy link
Collaborator

cooljeanius commented Dec 14, 2021 •
edited

I dunno what to do about this...
Screen Shot 2021-12-13 at 23 11 41

(This is S13, "Scouting", btw... possibly related to issue #24?)
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Dec 14, 2021
@cooljeanius
attempting to debug nemaara/A_New_Order#39
64167cf
@cooljeanius cooljeanius mentioned this issue Dec 15, 2021
Closed
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Dec 15, 2021
@cooljeanius
Update 13_Scouting.cfg
74dd61c 
found out the cause of nemaara/A_New_Order#39; it was an excess dollar sign. Removing it means I can remove some debugging things, too
@cooljeanius
Copy link
Collaborator Author

cooljeanius commented Dec 15, 2021 •
edited

ok so cooljeanius/A_New_Order@74dd61c fixes it on my end; I'm going to leave this open until it's merged here, though

(I'll be doing a separate PR that includes it after #36 is merged)

@cooljeanius cooljeanius mentioned this issue Mar 25, 2022
Closed
cooljeanius added a commit to cooljeanius/A_New_Order-1 that referenced this issue Mar 25, 2022
@cooljeanius
additional work porting to BfW 1.16
c8087e8 
This ought to be equivalent to cooljeanius/A_New_Order@43565fe..44013a3
Bugs addressed, in order of the commits in my repo addressing them:
Addresses #16 (doesn't fix it entirely, though)
Closes #30
Closes #18
Closes #15
Closes #31
Closes cooljeanius/A_New_Order#12
Doesn't actually do anything about #24, despite adding a comment referring to it
Closes nemaara#39
Doesn't really do anything about #19, despite adding comments referring to it
@cooljeanius cooljeanius mentioned this issue Mar 25, 2022
Merged
@cooljeanius
Copy link
Collaborator Author

ok so cooljeanius/A_New_Order@74dd61c fixes it on my end; I'm going to leave this open until it's merged here, though

(I'll be doing a separate PR that includes it after #36 is merged)

the "separate PR that includes it" is PR #43 now

@cooljeanius cooljeanius added the bug Something isn't working label May 29, 2022
@cooljeanius cooljeanius added this to the 1.4.1 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

additional work porting to BfW 1.16 cooljeanius/A_New_Order-1
1 participant
@cooljeanius