Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hungarian translation #93

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

cooljeanius
Copy link
Collaborator

@cooljeanius cooljeanius commented Dec 24, 2022

So, @kele17 sent me a new hu.po file by email, for issue #10... it doesn't look quite right, though; @celerini can you review please?

sent by @kele17 by email
@celerini
Copy link
Contributor

Thanks for an interesting task.

What I found out so far:

  • the biggest problem is, that both the new file and the first @kele17 attempt are cut after message number 1389, thus despite @kele17 efforts, there are 1697 missing trailing messages in kele17's hu.po files

  • the new file is now correctly wrapped after 79th character - it's good, but line endings are set to CRLF (Windows), which is bad

  • there are still errors in messages with a context, as I already stated in restore hu.po broken by a8013d3 #91

  • Poedit shows me ⚠️ for various minor errors - missing or superfluous spaces, differences in terminal punctuation...

So from my point of view this PR should be dropped.

To help @kele17 and save his efforts I repaired his hu.po files:

The repaired files are still far from merging, thus here are my recommendations to @kele17:

  • choose one of my repaired files if you don't have any better
  • download raw file: three dots icon -> View file -> Raw, Ctrl+S (save)
  • open this hu.po file in Poedit, verify in bottom status line that there are 3086 messages altogether
  • set LF line endings: Edit -> Preferences -> Advanced -> Line endings: Unix (recommended)
  • translate messages with a context correctly
  • resolve every message with ⚠️ in Poedit
  • do not translate further, instead send us your fixed hu.po file, so I can easily check if we understand each other and your work can be merged

sent from @kele17 by email
@cooljeanius
Copy link
Collaborator Author

ok, @kele17 has sent a new pofile... this one looks like it now diffs properly, at least; I haven't reviewed the whole thing... (will probably want to squash when merging)

@cooljeanius
Copy link
Collaborator Author

ok, @kele17 has sent a new pofile... this one looks like it now diffs properly, at least; I haven't reviewed the whole thing... (will probably want to squash when merging)

ok so yeah I've looked over the rest of it now and it looks a lot better; I can't comment as to the correctness of the words, but I think I'll merge it soon, unless @celerini has something to say within 24 hours.

@celerini
Copy link
Contributor

All major errors were fixed, thanks.

There are still messages with ⚠️ in Poedit - some false positives (those with a context), some may be intended (I would appreciate a translator comment in such cases) and some may be real errors, which should be fixed. But it can be done later.

In my opinion this PR can be merged now. Squashing looks reasonable in this case.

@kele17
Copy link

kele17 commented Dec 29, 2022

I started from the beginning. Get the repaired file, and make some new translated string, just to see the errors. Fuzzy string and untranslated strings will bw translated soon, maybe a week. I will send it to Eric, if it is ready.
Sorry for inconvenience, i was not directly connected to i18n process, now was this new for me. And have a technical problem with my notebook too, it was in service for a month. Now it seems everything ok. so i will send the whole revised file soon.

@cooljeanius
Copy link
Collaborator Author

All major errors were fixed, thanks.

There are still messages with ⚠️ in Poedit - some false positives (those with a context), some may be intended (I would appreciate a translator comment in such cases) and some may be real errors, which should be fixed. But it can be done later.

In my opinion this PR can be merged now. Squashing looks reasonable in this case.

OK, merging and squashing now, then

@cooljeanius cooljeanius merged commit c047fc1 into nemaara:master Dec 29, 2022
@cooljeanius cooljeanius deleted the hungarian_translation_update branch December 29, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants