Customize CI Build Phrases #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nemccarthy code review please |
|
It's being tested and just works :)
|
|
This is a good change but would it make more sense as a global config setting? And maybe move skip there too? |
|
+1 for some global config but there also seems a need for this to be configured per project. Thanks for the PR! |
nemccarthy
added a commit
that referenced
this pull request
Oct 12, 2015
Add 'sourceCommitHash' parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
test this pleaseis too verbose to type (and is easy to make typo).Allowing customize
ciBuildPhrasesis much more flexible, just likeciSkipPhrases.PS. I have no idea how to test jenkins plugin, so this pr is still not tested :(