This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add TLS certificate reloading on SIGHUP #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when using short-lived TLS certificates, for example when using Let's Encrypt certificates or certificates issued from Vault itself.
Vault itself reloads configured certificates on SIGHUP. One difference is that here a signal handler is not set up if TLS is not configured, so if you don't configure TLS, SIGHUP will kill the vltgatekeeper process like it does currently.
The main thing I'm unsure of is where to place this code. There are some certificate-y things in
gatekeeper/cert.gobut they are a bit different than this stuff.Thanks for the great project 🙏.