Skip to content

[JAV-52, JAV-54, JAV-57, JAV-27, JAV-58, JAV-59] Small issue fixes #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 8, 2019
Merged

[JAV-52, JAV-54, JAV-57, JAV-27, JAV-58, JAV-59] Small issue fixes #284

merged 22 commits into from
Oct 8, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Oct 4, 2019 •
edited
Loading

  • Fixed MosaicAmountView issue. Now return observable of array
  • Optimised Account restriction endpoints payload. Removed wrappers (Breaking Change)
  • Fixed package.json definition package in wrong place issue
  • Fixed http repository error handling issue
  • Fixed wrong interface used in Alias
  • Fixed MosaicId significant byte not detected properly in TransactionPayload
  • Fixed only MIJIN_TEST network type allowed in NetworkTypeHttp

Issue: #277 #276 #285 #246 #286 #287

@coveralls
Copy link

coveralls commented Oct 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 720: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@rg911 rg911 changed the title [JAV-52 & JAV-54] MosaicAmountView Fix and AccountRestriction Improvement [JAV-52, JAV-54, JAV-57] Small issue fixes Oct 5, 2019
@rg911 rg911 changed the title [JAV-52, JAV-54, JAV-57] Small issue fixes [JAV-52, JAV-54, JAV-57, JAV-27] Small issue fixes Oct 5, 2019
@rg911 rg911 changed the title [JAV-52, JAV-54, JAV-57, JAV-27] Small issue fixes [JAV-52, JAV-54, JAV-57, JAV-27, JAV-58] Small issue fixes Oct 6, 2019
@rg911 rg911 changed the title [JAV-52, JAV-54, JAV-57, JAV-27, JAV-58] Small issue fixes [JAV-52, JAV-54, JAV-57, JAV-27, JAV-58, JAV-59] Small issue fixes Oct 7, 2019
rg911 and others added 12 commits October 7, 2019 19:00
@rg911
Changed metadataTransactionService key from string to UInt64
b61506a
@contractormario
Rename, relax validation, convert to arraybuf instead of hex
11934dc
@rg911
Merge pull request symbol#288 from contractormario/task/g278_key_gene…
7615a42 
…rator

Implement KeyGenerator
@rg911
JAV-52 [github symbol#276] Fixed mosaicAmountView observable issue
cb000ff 
Fixed @types/long dev package in package.json
@rg911
JAV-54 [Github symbol#277] Improved AccountRestriction payload
7271217
@rg911
JAV-57 [Github symbol#285] Fixed error handling issue
df11c9f
@rg911
JAV-27 [Github symbol#246] Fixed Alias issue
266f064
@rg911
Added @InterAl for abstract mathod
7f3bbd0
@rg911
JAV-58 [Github symbol#286] Fixed MosaicId significant byte not detected
7acd163
@rg911
JAV-59 [Github symbol#287] Fixed network http only allow MIJIN_TEST i…
709680c 
…ssue
@rg911
Changed metadataTransactionService key from string to UInt64
e5e216f
@rg911
Merge branch 'small_fixes_prior_rc' of github.com:rg911/nem2-sdk-type…
62a384b 
…script-javascript into small_fixes_prior_rc
@rg911 rg911 merged commit 56fbd02 into symbol:master Oct 8, 2019
@rg911 rg911 deleted the small_fixes_prior_rc branch October 8, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarcia360 dgarcia360 Awaiting requested review from dgarcia360

@fboucquez fboucquez Awaiting requested review from fboucquez

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rg911 @coveralls @evias @contractormario