Skip to content

JAV-63 Make sure Mosaic list is ordered in transfer transaction #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from Oct 14, 2019
Merged

JAV-63 Make sure Mosaic list is ordered in transfer transaction #296

merged 10 commits into from Oct 14, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Oct 10, 2019

  • Fixed sortMosaics which has already been crated in before but not working properly.
  • Added Unit tests

Issue: #294

@rg911 rg911 requested review from evias and fboucquez October 10, 2019 20:43
@coveralls
Copy link

coveralls commented Oct 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 766

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 765: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 743

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 740: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

evias
evias reviewed Oct 14, 2019
View reviewed changes
@rg911 rg911 merged commit bf10cd2 into symbol:master Oct 14, 2019
@rg911 rg911 deleted the task/g294_mosaic_ordering branch December 3, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fboucquez fboucquez Awaiting requested review from fboucquez

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias