Skip to content

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Oct 11, 2019

  • Created UnresolvedMapping Util class
  • Updated Transactions signature to allow NamespaceId (MosaicRestrictions, MosaicMetadata)
  • Update serialization (DTO & Binary payload) to cope with alias
  • Created / Added unit and integration tests for above changes.

Issue: #295

@rg911 rg911 requested review from evias and fboucquez October 11, 2019 15:11
@coveralls
Copy link

coveralls commented Oct 11, 2019

Pull Request Test Coverage Report for Build 744

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 740: 0.0%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 11, 2019

Pull Request Test Coverage Report for Build 764

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 763: 0.0%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

rg911 added 4 commits October 12, 2019 19:40
…ransaction' of github.com:NEMStudios/nem2-sdk-typescript-javascript into task/g295_namespace_id_in_metadata_mosaic_restriction_transaction
@rg911 rg911 merged commit dbb5c58 into symbol:master Oct 14, 2019
@rg911 rg911 deleted the task/g295_namespace_id_in_metadata_mosaic_restriction_transaction branch December 3, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants