Fix NamespaceId and MosaicId hash algorithm resolution #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
suggested changes
Nov 19, 2019
added 4 commits
November 20, 2019 13:29
…icId.createFromNonce
|
default networkType removed; PR should be good to fix namespaceId hash and mosaicId hash generation on keccak using network type to resolve signature schema. |
rg911
suggested changes
Nov 20, 2019
| * @param encoded | ||
| * | ||
| * @param {string} encoded Hexadecimal notation of namespace id | ||
| * @param {NetworkType} networkType The network type for hash algorithm resolution |
| constructor(id: string | number[]) { | ||
| constructor( | ||
| id: string | number[], | ||
| networkType?: NetworkType, |
There was a problem hiding this comment.
no its intended ; using ! in else block.
When you instantiate a NamespaceId by number[] you don't need any NetworkType and would be wrong to default it then to something.
When you instantiate by string, you always need the networkType.
rg911
approved these changes
Nov 21, 2019
|
So finally NamespaceId name resolution depends on the hash algorithm/network type? I have this PR on hold: https://github.com/nemtech/nem2-sdk-java/pull/165 Should I pick it up? |
|
closed not merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
networkTypeparameter forNamespaceIdandMosaicIdconstructorsFixed
mosaicIdandnamespaceIdstatic method now resolving hash algorithm fromnetworkTypeparameters, defaulted to NetworkType.MIJIN_TESTChanged
IdGenerator.