Open Api Library

[fboucquez]

• Removed open api generated code
• Removed open api templates
• Added open api generated dependency
• Updated open api imports
• Patched a few client call lines
• Added TransactionHttp tests mocking open API route clients.

Generator:
https://github.com/NEMStudios/nem2-open-api-generator

NPM Package:
https://www.npmjs.com/package/nem2-sdk-openapi-typescript-node-client

Maintainer @rg911 @fboucquez

[rg911]

Added small change to fix #405. sorry @fboucquez I missed that issue in our previous discussion.
Otherwise this PR looks good to me.

[rg911]

@evias we have been discussing this in previous closed PRs. I second the idea wrapping OpenAPI codes into a lib package. A few benefit here:

1. Future http client changes made easier, and we can avoid big changes in PRs
2. Standard OpenAPI generator template has got a lot lint issues,
3. Improve the test coverage up to more than 20%
4. Controlled lib version
5. First setup for automated CI / CD

[evias]

I suggest to have the package reviewed for adding to nemtech organization such that its content follows the same review as the SDK/catbuffer generators.

[rg911]

I suggest to have the package reviewed for adding to nemtech organization such that its content follows the same review as the SDK/catbuffer generators.

Certainly can. Buy the way, the package is generated using official openAPI generator and standard template. Content would be the same as before.

[fboucquez]

TransactionStatus is part of the SDK API. If we add the enums here we are exposing generated code to the clients when everything other open API code is wrapped/hidden. This would make it harder to update if we want to change the generated clients eventually. For example, Java has 2 different generated clients, another possible client could be direct to DB one. Not a big issue at this stage.