Skip to content

Adding missing export #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jan 29, 2020
Merged

Adding missing export #422

merged 1 commit into from Jan 29, 2020

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Jan 16, 2020

  • Exported missing classes
  • Fixed lint

Fixed #421

@rg911
Fixed #421
887b190 
- Exported missing classes
- Fixed lint
@rg911 rg911 requested review from fboucquez and evias and removed request for fboucquez January 16, 2020 11:10
@rg911
Copy link
Contributor Author

rg911 commented Jan 16, 2020

Should TSLint complain about Trailing commas?

https://eslint.org/docs/rules/comma-dangle

It complains about missing trailing comma using current tsling setup

@fboucquez fboucquez self-requested a review January 29, 2020 00:14
@rg911 rg911 merged commit bb7e54b into symbol:master Jan 29, 2020
@fboucquez fboucquez deleted the task/g421_export_missing_classes branch April 13, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evias evias Awaiting requested review from evias

1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export RepositoryFactoryHttp
2 participants
@rg911 @fboucquez