Skip to content

fix #446 #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2020
Merged

fix #446 #447

merged 2 commits into from
Feb 17, 2020

Conversation

AnthonyLaw
Copy link
Member

Remark

  • deleted extractBeneficiary, because it seem no longer use it.

@AnthonyLaw AnthonyLaw requested review from evias and rg911 February 13, 2020 17:05
rg911
rg911 reviewed Feb 13, 2020
View reviewed changes
Copy link
Contributor

@rg911 rg911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it been tested against the server? Would be better to add a simple e2e test to make sure it works

@AnthonyLaw AnthonyLaw requested a review from rg911 February 15, 2020 15:06
@rg911 rg911 merged commit 29bea91 into symbol:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evias evias Awaiting requested review from evias

1 more reviewer

@rg911 rg911 rg911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnthonyLaw @rg911