Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key derivation using sha512 #445

Merged
merged 9 commits into from Feb 18, 2020

Conversation

@rg911
Copy link
Member

rg911 commented Feb 12, 2020

This PR introduced quite a few Breaking changes:

  • All Key derivation and signing hash are now using SHA512. Means all KeyPairs generated and Addresses derived from publicKey are now having different hex values.
  • Cleared the bond between NetworkType and SigningSchema. SigningSchema has now been removed from the SDK. There's no Keccak / SHA3 switch anymore.
  • Key pair generation is now using nacl.sign.keypair from the standard nacl js script.
  • Transaction signing is now using nacl.sign.detached from the standard nacl js script.
  • Legacy catapult-nacl is still used for SharedKey derivation due to the multiplier methods is internal and not exported in the nacl js.

This PR also:

  • Removed unused legacy catapult-nacl code in Utilities class
  • Fixed the tests
  • Fixed a few lint issues
rg911 added 3 commits Feb 11, 2020
- Changed key derivation using sha512
- Removed signSchema
- Updated tests
@rg911 rg911 requested review from fboucquez, dgarcia360 and evias Feb 12, 2020
rg911 added 3 commits Feb 12, 2020
Fixed #448
- Added custom error message for ECONNREFUSED
@rg911

This comment has been minimized.

@rg911 rg911 force-pushed the NEMStudios:task/g441_key_derivation_sha512 branch from 032fa1c to e8a957a Feb 17, 2020
@rg911 rg911 merged commit fd830ca into nemtech:master Feb 18, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.