feat: transaction signWith method broken into smaller methods #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
reviewed
May 28, 2021
src/model/transaction/Transaction.ts
Outdated
| * @param {number[]} rawTxSigningBytes - Raw transaction siging bytes | ||
| * @returns {number[]} Signature byte array | ||
| */ | ||
| public static signRawTx(privateKey: string, rawTxSigningBytes: number[]): number[] { |
There was a problem hiding this comment.
Should the public method use Uint8Array for input and output rather than number[]?
There was a problem hiding this comment.
Makes sense, updated.
fboucquez
approved these changes
May 31, 2021
rg911
approved these changes
Jun 8, 2021
src/model/transaction/Transaction.ts
Outdated
| * @param {number[]} rawTxSigningBytes - Raw transaction siging bytes | ||
| * @returns {number[]} Signature byte array | ||
| */ | ||
| public static signRawTx(privateKey: string, rawTxSigningBytes: number[]): number[] { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal of breaking down the
Transaction.signWithmethod into smaller methods(corresponding to the steps)There are three parts of signing:
1- Preparing the byte array
2- Signing the byte array with private key (this happens on hardware wallet in some cases)
3- Preparing the signed raw tx - payload
4- Return SignedTransaction object