Add keras-model.ipynb to ./doc/examples #84
Conversation
|
This looks great, thanks very much for putting it together! If it's alright with you, I'll add some edits to combine this and https://www.nengo.ai/nengo-dl/examples/pretrained-model.html into the same example. I think it'd be a nice story "here's how you could add a tf-slim model to nengo-dl, and here's how you'd add a keras model to nengo-dl". |
|
Yes, definitely alright with me. That will probably help with consistency of tone in the docs too. |
|
Added a commit merging those two examples. I ended up putting the Keras example first, since I think it's a better introduction (there's more weirdness associated with setting up the tf-slim TensorNode). Let me know if that looks good to you, or feel free to suggest any changes (or just make the edits directly). The only other thing to do before merging is that we need you to sign the contributor agreement, which is done by opening a PR adding your name to this file https://github.com/nengo/nengo.github.io/blob/src/people.rst. Thanks again for your work on this, can definitely say after going through the example in detail that this is a nice addition to the documentation. |
|
Just a gentle ping on the status of this @NickleDave. No worries at all if you haven't had a chance to look at it yet, I just wanted to make sure you weren't waiting on me. |
|
Will look at it tonight! Sorry for the hold-up, it's been on my to-do list, promise |
NickleDave
force-pushed
the
add-keras-model-to-examples
branch
from
05b545c
to
919d2a5
Compare
|
Just read through it. LGTM! I wouldn't change a thing. I fetched upstream and rebased on master, hope that didn't mess everything up. Will submit a separate PR for the contributor agreement |
|
Oh, actually, one thing. I can insert if if you think that's appropriate / necessary. |
drasmuss
force-pushed
the
add-keras-model-to-examples
branch
2 times, most recently
from
d10f6b1
to
6dfaeec
Compare
Rename pretrained-model.ipynb to tensorflow-models.ipynb
drasmuss
force-pushed
the
add-keras-model-to-examples
branch
from
6dfaeec
to
c15da2c
Compare
There was a problem hiding this comment.
Cleaned up the history and added a changelog entry. I didn't add a link to the docs license, since I figured that we do already refer to the general TensorFlow license on the LICENSE.rst page (and although the tensorflow/docs license is technically separate from tensorflow/tensorflow, they are the same license so I don't think we need to be too worried about that). I'll merge this in now, thanks again!
|
Great! Happy to contribute, and thank you for walking me through the process |
No description provided.