Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to support recent changes in nengo core #94

Merged
merged 12 commits into from
Jul 23, 2019
Merged

Updates to support recent changes in nengo core #94

merged 12 commits into from
Jul 23, 2019

Conversation

drasmuss
Copy link
Member

The significant changes are:

  • Support new SimPES operator
  • Support sparse transforms
  • Support new LinearFilter implementation

@drasmuss drasmuss force-pushed the core-updates branch 3 times, most recently from 69139ee to 43d4656 Compare July 3, 2019 13:13
@drasmuss
Increase minimum numpy version to 1.14.5
96d56be 
Required by TensorFlow 1.14
@drasmuss
Use nengo core SimPES operator
a5ec68c 
If it is available, rather than nengo-dl's version.

Set minimum Nengo version to 2.8.0

Move nengo backwards compatibility logic to compat.py
@drasmuss
Change op_constant to use numpy dtype
02dcc20 
Rather than using tensorflow dtype. This matches other
similar functions (e.g. `constant`).
@drasmuss
Add a nengo-dl version of the builder dtype test
d840398
@drasmuss
Fix Simulator seed based on Network seed
bdbb143
@drasmuss
Combine DotIncBuilder and SparseDotIncBuilder
1f54ed1
@drasmuss
Add support for sparse transforms
8cb5ddb 
Add optional scipy install to ci builds
@drasmuss
Update LinearFilter implementation to match core
4fbac76
@drasmuss
Handle float64 sparse matmul on GPU
694205a
@drasmuss drasmuss force-pushed the core-updates branch 2 times, most recently from ead7c08 to d0d4755 Compare July 10, 2019 20:55
@drasmuss drasmuss mentioned this pull request Jul 17, 2019
Closed
hunse
hunse reviewed Jul 22, 2019
View reviewed changes
nengo_dl/compat.py Outdated Show resolved Hide resolved
tbekolay
tbekolay approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just one minor inline comment that could be acted upon here, but I don't think it's worth slowing down the PR, just something that could be modified in the future. Merging!

nengo_dl/tests/test_simulator.py Show resolved Hide resolved
nengo_dl/compat.py Outdated Show resolved Hide resolved
@tbekolay
Update to Nengo Bones 0.3
880e7e9 
Which has the side effect of updating to Nengo Sphinx Theme 1.0.
Some redirected links have been fixed here as well.
@tbekolay tbekolay merged commit 880e7e9 into master Jul 23, 2019
@tbekolay tbekolay deleted the core-updates branch July 23, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunse hunse hunse left review comments

@tbekolay tbekolay tbekolay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drasmuss @tbekolay @hunse