-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethinking the Jupyter progress bar. #1087
Comments
The Jupyter progress bar will crash the notebook when used with the 5.1.0 notebook release. After that the page needs to reloaded to restore communication between the notebook and kernel. This might be due to the way we inject the JavaScript into notebook. Currently we are trying to support a number of notebook versions. It would be nice if we could drop support for older versions to reduce code complexity (and testing burden) with the next minor release. After all it is nice, but non-essential feature (there is still the ASCII progress bar or the possibility to use an older Nengo version if desired). Should we also do bugfix release to at least not break the notebook (fallback to the ASCII bar)? It is probably not obvious to the average user why the notebook breaks if they happen to use the Jupyter progress bar. On the other hand, the workaround is easy once known (just don't do Thoughts, @tbekolay? Also, should we rename |
I'm fine dropping support for older versions (people can revert to an earlier released version that works with older notebook versions if they're annoyed), and yeah, if the current version is crashing the notebook I say we remove it for the time being. If a PR for that gets merged we can do a quick release. |
I can't figure out which older versions actually work because the versioning in the Jupyter eco system is a mess. There is a multitude of potentially relevant packages ( |
The difficulties in retiring the old progress bar apart, I made an exciting discovery: The rich display system of IPython supports updating of outputs since version 5.x. This allows for a much more robust and easier implementation of the progress bar without widgets (or the need to do |
Sweet :)
…On October 24, 2017 8:39:20 PM EDT, Jan Gosmann ***@***.***> wrote:
The difficulties in retiring the old progress bar apart, I made an
exciting discovery: The rich display system of IPython supports
updating of outputs since version 5.x. This allows for a much more
robust and easier implementation of the progress bar without widgets
(or the need to do %load_ext nengo.ipynb).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on
GitHub<#1087 (comment)>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AB5JU7IakG04h6JtnVIUD_-TtUYuND9_ks5svoM4gaJpZM4IzQ5q>.
|
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
Based on the rich display system, supports IPython >= 5. Addresses #1087.
This is used in Jupyter lab. Closes #1087.
The Jupyter widget API changed quite a bit over the last couple of versions, but seems to get more stable now that they moved it to its own package. We should take another look at the current recommended way to implement and distribute such widgets and see whether it makes sense to adopt the recommended approach for Nengo.
The text was updated successfully, but these errors were encountered: