Drop NumPy 1.6 support. #1147
Merged
Drop NumPy 1.6 support. #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Under which heading would the changelog entry go? The usual categories don't really fit. |
Behavioral changes I guess is the closest? |
|
LGTM. |
|
LGTM. I added a couple of minor fixups. I was looking through the Numpy 1.7 release notes and trying to see if there's anything else we can simplify. The only thing I noticed was they added |
|
Still LGTM btw. |
|
Added the changelog entry. |
|
I'll give this a look over and merge this evening 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Drops support for NumPy 1.6 by bumping version numbers in the requirements and removing it from the test martix.
Motivation and context:
The last NumPy 1.6 release is more than 4 years old. By not supporting it any longer some features will be easier to implement, namely most of the logic in #1016 would not be required. At the last dev meetings no objections were raised.
Interactions with other PRs:
#1016
How has this been tested?
Hasn't been tested. I think the only thing worth to test would be whether I did not overlook any reference to NumPy 1.6, but no idea what else to do than grepping for
1.6.Where should a reviewer start?
Files changed as usual, it might make sense to view the commits individually.
How long should this take to review?
Types of changes:
Checklist:
Still to do: