-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop NumPy 1.6 support. #1147
Drop NumPy 1.6 support. #1147
Conversation
Under which heading would the changelog entry go? The usual categories don't really fit. |
Behavioral changes I guess is the closest? |
LGTM. |
LGTM. I added a couple of minor fixups. I was looking through the Numpy 1.7 release notes and trying to see if there's anything else we can simplify. The only thing I noticed was they added |
Still LGTM btw. |
Added the changelog entry. |
I'll give this a look over and merge this evening 👍 |
Description:
Drops support for NumPy 1.6 by bumping version numbers in the requirements and removing it from the test martix.
Motivation and context:
The last NumPy 1.6 release is more than 4 years old. By not supporting it any longer some features will be easier to implement, namely most of the logic in #1016 would not be required. At the last dev meetings no objections were raised.
Interactions with other PRs:
#1016
How has this been tested?
Hasn't been tested. I think the only thing worth to test would be whether I did not overlook any reference to NumPy 1.6, but no idea what else to do than grepping for
1.6
.Where should a reviewer start?
Files changed as usual, it might make sense to view the commits individually.
How long should this take to review?
Types of changes:
Checklist:
Still to do: