Add standardized network inputs and outputs #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seanny123
approved these changes
Apr 18, 2017
tcstewar
approved these changes
Apr 18, 2017
tbekolay
force-pushed
the
net-inputs-non-breaking
branch
from
0e912bf
to
cf76989
Compare
This makes the product and circular convolution network adhere to the newly defined standard for network inputs which should be named 'input_*'. This does not touch the names of inputs to the SPA networks as most of them will be refactored in nengo_spa anyways. The old names are still accessible. For technical reasons, they do not raise a DeprecationWarning, though that would have been preferable. Addresses #887.
tbekolay
force-pushed
the
net-inputs-non-breaking
branch
from
cf76989
to
0eb77e6
Compare
tbekolay
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This makes the product and circular convolution network adhere to the newly defined standard for network inputs (#887) which should be named input_*. The old inputs are still available to keep backwards compatibility. They will not produce a deprecation warning as this is not possible in a backwards compatible way. Furthermore, this PR deprecates the
netargument. As discussed before this argument was rarely used and in almost all uses cases the new**kwargspassed tonengo.Networkprovide the same functionality. This is required to allow for a deprecation on the old inputs in the future.For consistency I made the
netargument also obsolete on other network creation functions. In some other networks I also introduced inoutputnode to provide a common interface.Interactions with other PRs:
new-spa/nengo_spa uses the new input names.
This is a non-breaking version of #1179 for the inclusion in one of the next minor releases. #1179 is for the inclusion in the next major release.
How has this been tested?
Unit tests still pass.
How long should this take to review?
Types of changes:
Checklist: