Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing super calls #1298

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Added missing super calls #1298

merged 1 commit into from
Apr 18, 2017

Conversation

Seanny123
Copy link
Contributor

Motivation and context:
There were a few missing super calls that were causing errors in TravisCI, as seen in #1296 and #1297

Interactions with other PRs:
Fixes errors in #1296 and #1297

How has this been tested?
Passed the tests on TravisCI

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • All new and existing tests passed.

@Seanny123 Seanny123 mentioned this pull request Apr 18, 2017
Merged
5 tasks
tbekolay
tbekolay approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Seanny123!

@tbekolay tbekolay merged commit f09dfc0 into master Apr 18, 2017
@tbekolay tbekolay deleted the flake8-fixes branch April 18, 2017 14:59
@Seanny123 Seanny123 mentioned this pull request Apr 25, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgosmann jgosmann jgosmann approved these changes

@tbekolay tbekolay tbekolay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seanny123 @tbekolay @jgosmann