Exception when module isn't added to spa #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,13 +31,13 @@ def input1(t): | |||
| """ | |||
| def __init__(self, label=None, seed=None, add_to_container=None, **kwargs): | |||
| super(Input, self).__init__(label, seed, add_to_container) | |||
| print("HELLO") | |||
|
Thanks for the review Jan. I made the changes you suggested. Let me know if it's okay now and I'll squash it and mark it for merge. BTW, did @tbekolay ever tell you that you're allowed to merge things into this repository now? |
I don't remember it? One more thing: There is a bunch of code in the docstring. That should probably formatted as code (so that it looks nice in the HTML documentation). |
|
Fixed the docstrings. |
|
Is there anything in here worth putting in the changelog? |
|
Was just about to ask the same question :P |
jgosmann
added a commit
that referenced
this pull request
Aug 6, 2015
|
Made a PR #804 with changelog entries added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730 by raising an exception when a module is added to a network, but not as an attribute