-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception when module isn't added to spa #791
Conversation
@@ -31,13 +31,13 @@ def input1(t): | |||
""" | |||
def __init__(self, label=None, seed=None, add_to_container=None, **kwargs): | |||
super(Input, self).__init__(label, seed, add_to_container) | |||
print("HELLO") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug code ...
Thanks for the review Jan. I made the changes you suggested. Let me know if it's okay now and I'll squash it and mark it for merge. BTW, did @tbekolay ever tell you that you're allowed to merge things into this repository now? |
I don't remember it? One more thing: There is a bunch of code in the docstring. That should probably formatted as code (so that it looks nice in the HTML documentation). |
Fixed the docstrings. |
Is there anything in here worth putting in the changelog? |
Was just about to ask the same question :P |
Made a PR #804 with changelog entries added. |
Fixes #730 by raising an exception when a module is added to a network, but not as an attribute