Check in container build code #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wweic
suggested changes
Apr 3, 2019
|
|
||
| RUN mkdir -p /home/model-server && cd /home/model-server \ | ||
| && git clone --recursive https://github.com/neo-ai/neo-ai-dlr \ | ||
| && cd neo-ai-dlr && git checkout 7dd33f829062e19df3c0f175912199ad176da970 \ |
There was a problem hiding this comment.
why 7dd33f829062e19df3c0f175912199ad176da970?
There was a problem hiding this comment.
@wweic Let's keep it for now, as I haven't tested the container against the latest commit. I'll submit a follow-up PR where the Docker build will embed the latest DLR artifact into the container. The follow-up PR will also have tests for containers.
There was a problem hiding this comment.
OK. Please create an issue and follow up with a PR.
wweic
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to automatically build inference containers using the Jenkins CI pipeline.
The containers use the MXNet Model Server for model serving. (Despite the name, MMS is able to accommodate custom backend logic.)
Future items: