Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a network should delete all dependent resources #7

Closed
dicarlo2 opened this issue Dec 24, 2017 · 0 comments
Closed

Deleting a network should delete all dependent resources #7

dicarlo2 opened this issue Dec 24, 2017 · 0 comments
Assignees
@dicarlo2
Labels
good first issue help wanted kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon.

Comments

@dicarlo2
Copy link
Contributor

Description

Deleting a network (or more generally, deleting a resource) should delete all dependent resources.

Steps to Reproduce

  1. create net neo
  2. delete net neo

Expected behavior: Automatically created wallet "master" should be deleted.

Actual behavior: It is not.

Reproduces how often: 100%

Versions

v0.0.1

Additional Information

We could implement this plugin by plugin, but it might be nice to have a generic cleanup call for resources. I.e. a declarative way for a plugin to tell the server framework that the resource it just created is dependent on another resource, and to delete it if the other resource is deleted. Perhaps it should also extend to stopping and starting? Marked as a bug in addition to an enhancement because it causes weird behavior in the cli.
@dicarlo2 dicarlo2 added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. good first issue help wanted priority/important-soon Must be staffed and worked on either currently, or very soon. labels Dec 24, 2017
@dicarlo2 dicarlo2 mentioned this issue Dec 24, 2017
Closed
@dicarlo2 dicarlo2 self-assigned this Dec 26, 2017
dicarlo2 added a commit that referenced this issue Dec 26, 2017
@dicarlo2
Delete dependent resources and deactivate wallet #7 #11
26fefee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dicarlo2 dicarlo2

Labels
good first issue help wanted kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dicarlo2