feat(cli): add support for outputting .avm and .debug files from @neo-one/cli #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencercorwin
requested changes
Jun 24, 2020
spencercorwin
requested changes
Jun 25, 2020
There was a problem hiding this comment.
I think we should try to output something better for the id and entrypoint properties. Maybe by looking at what the debugger uses them for and then just creating something to fit that purpose? Idk. We should discuss more over VC.
We should update the compile e2e test for this too. Which should be very easy. I can do it in a separate PR if you want since I wrote that test originally.
danwbyrne
force-pushed
the
debugger
branch
2 times, most recently
from
3eb6964
to
82ce408
Compare
spencercorwin
requested changes
Jun 25, 2020
Codecov Report
|
danwbyrne
force-pushed
the
debugger
branch
2 times, most recently
from
01038fd
to
3fccc93
Compare
danwbyrne
changed the title
danwbyrne
force-pushed
the
debugger
branch
4 times, most recently
from
5cc5a50
to
0aa817c
Compare
This was referenced Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2002 #2000
Description
Adds several new CLI flags for the
neo-one compilecommand. These flags are:--json- defaults totrue, outputs a.contract.jsonand.neoone.abi.json.--avm- defaults tofalse, outputs the contract bytecode as a.avmfile and a compatible.abi.jsonfile.--opcodes- defaults tofalse, outputs a.avm.txtof disassembled bytecode from the.avmfile.--debug- defaults tofalse, ifjsonis specified outputs the uncompressed.debug.json. Ifavmis specified outputs the compressed.avmdbgnfo.Testing
If you have a contract/neo-one config you can build this and run:
against your test contract(s) with the various flags.
Further Work
While we are able to output
.avmand.abifiles now there is still some work to be done in integrating with the neo toolkit. See #2113 for more information